[ad-hoc filters] Remove legacy split in /explore #5533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5533 +/- ##
==========================================
- Coverage 63.31% 63.31% -0.01%
==========================================
Files 349 349
Lines 22181 22180 -1
Branches 2463 2463
==========================================
- Hits 14044 14043 -1
Misses 8123 8123
Partials 14 14
Continue to review full report at Codecov.
|
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Aug 1, 2018
(cherry picked from commit e52518c)
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 1, 2018
[ad-hoc filters] Remove legacy split in /explore (apache#5533)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unnecessary step of splitting ad-hoc filters into legacy filters for the
/exploreendpoint. This merely unnecessarily pollutes (in a non-harmful way) the form-data (including that in the URL) with legacy constructs. These clauses are ignored given that theadhoc_filtersfield is guaranteed to exist (by construction).Note the only place we currently need to split ad-hoc filters to legacy (base) filters in the
BaseViz.query_obj(...)as the query logic still uses the legacy constructs. Note a migration is not needed here given the code correctly converts and then removes the legacy constructs, but could be merited for cleaning up erroneous fields in the form-data.to: @GabeLoins @graceguo-supercat @michellethomas @mistercrunch @timifasubaa