Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-5] Refactor pivot table #5705

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Aug 22, 2018

  • Extract slice and formData according to [SIP-5]

@williaster @conglei @graceguo-supercat

@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #5705 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5705      +/-   ##
==========================================
- Coverage   63.77%   63.73%   -0.04%     
==========================================
  Files         364      364              
  Lines       23097    23108      +11     
  Branches     2572     2573       +1     
==========================================
  Hits        14729    14729              
- Misses       8353     8364      +11     
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/visualizations/pivot_table.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5437efa...7a86b53. Read the comment docs.

@kristw kristw changed the title Refactor pivot table [SIP-5] Refactor pivot table Aug 24, 2018
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for all the hard work on untangling these!

@williaster williaster merged commit 5eff7a8 into apache:master Sep 5, 2018
kristw added a commit to kristw/incubator-superset that referenced this pull request Sep 12, 2018
* extract slice and formData

* rename variables

* update proptypes and add comments

(cherry picked from commit 5eff7a8)
@kristw kristw deleted the kristw-pivot-table branch September 18, 2018 01:02
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* extract slice and formData

* rename variables

* update proptypes and add comments
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* extract slice and formData

* rename variables

* update proptypes and add comments
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants