Autofocus aggregation in metric control #5717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5717 +/- ##
=======================================
Coverage 63.43% 63.43%
=======================================
Files 361 361
Lines 22977 22977
Branches 2558 2558
=======================================
Hits 14575 14575
Misses 8387 8387
Partials 15 15
Continue to review full report at Codecov.
|
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Focus button * Move autofocus to aggregation
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
* Focus button * Move autofocus to aggregation (cherry picked from commit f83ea23)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Focus button * Move autofocus to aggregation
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the aggregation select be focused when the overlay shows up:
The user can then press tab+enter to accept, or enter to choose a different aggregation.