Enable hot module replacement for React via react-hot-loader #5841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5841 +/- ##
=========================================
- Coverage 63.73% 63.64% -0.1%
=========================================
Files 368 374 +6
Lines 23219 23252 +33
Branches 2600 2600
=========================================
Hits 14799 14799
- Misses 8405 8438 +33
Partials 15 15
Continue to review full report at Codecov.
|
williaster
approved these changes
Sep 10, 2018
|
Thank you! This one is ready to merge. |
|
LGTM. Well done! |
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
…5841) * Install react-hot-loader * enable react-hot-reload for Explore, Dashboard, Profile and Sqllab * enable hmr for welcome page * enable hmr for welcome page * enable react hot module replacement for addSlice * fix lint * fix Welcome test * remove eslint comment
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…5841) * Install react-hot-loader * enable react-hot-reload for Explore, Dashboard, Profile and Sqllab * enable hmr for welcome page * enable hmr for welcome page * enable react hot module replacement for addSlice * fix lint * fix Welcome test * remove eslint comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What were changed?
react-hot-loaderand configure it to work with babelindex.jsxare renamed toApp.jsxand exported as hot module.index.jsxare thin shells that callsReactDOM.renderto render<App />Why?
Hot module replacement for react will enable us to develop the UI faster because when we make changes, the page keeps UI state and only replace the UI code affected by the change instead of reloading the entire page.
For example, you open an SQL editor, look up a few schema, switch tabs. When you modify code for one button and save, everything stays the same. Only the button will be changed.
Reference
Installed based on instruction here
https://github.com/gaearon/react-hot-loader
From the instruction page
@williaster @graceguo-supercat @xtinec @conglei