[cypress] Combine multiple tests under visualizations into single test to save running time #6019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am going to re-run to get more data point. |
Codecov Report
@@ Coverage Diff @@
## master #6019 +/- ##
==========================================
+ Coverage 64.6% 64.65% +0.04%
==========================================
Files 446 446
Lines 23814 23814
Branches 2639 2639
==========================================
+ Hits 15386 15396 +10
+ Misses 8415 8405 -10
Partials 13 13
Continue to review full report at Codecov.
|
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
…t to save running time (apache#6019) * add histogram test * add compare test * merge all vis tests under single test
6 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the work from #6007
tl;dr Based on the hypothesis that is there is an overhead to start up browser for each test, this PR nests all vis tests another level of
describe()inall.jsand tell cypress to ignore the individual test files._xxx.jsand add cypress rule to ignore any file that begins with underscore (_).all.jswhich wraps all the test under a single run using nesteddescribe()Good speed up both locally and on ci. First attempt on ci is 10mins compared to previous run of 15mins.
@graceguo-supercat @michellethomas @williaster