[select-star] Adding optional schema to view #6051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley-fix-select-star-view
branch
from
d4a7915
to
99c7819
Compare
Codecov Report
@@ Coverage Diff @@
## master #6051 +/- ##
=========================================
+ Coverage 77.74% 77.84% +0.1%
=========================================
Files 46 46
Lines 9400 9412 +12
=========================================
+ Hits 7308 7327 +19
+ Misses 2092 2085 -7
Continue to review full report at Codecov.
|
mistercrunch
reviewed
Oct 8, 2018
| @@ -1 +0,0 @@ | |||
| {{ content |safe }} | |||
There was a problem hiding this comment.
Oh god that was awful, thanks for getting rid of this.
mistercrunch
reviewed
Oct 8, 2018
superset/db_engine_specs.py
Outdated
| # table is not partitioned | ||
| return False | ||
| for c in columns: | ||
| if c['name'] == col_name: |
There was a problem hiding this comment.
NIT: c.get() is generally safer as it won't ever raise KeyError, though in this case the schema should be safe
|
LGTM |
john-bodley
force-pushed
the
john-bodley-fix-select-star-view
branch
from
99c7819
to
fc924e3
Compare
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Oct 8, 2018
(cherry picked from commit 1ee08fc)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a couple of aspects of the select-star logic including:
/select_starroute./select_starroute return a JSON response as opposed to HTML./select_starroute includes a partition (if appropriate)./tableroute includes a partition (if appropriate)†.where_latest_partitionfor Presto.where_latest_partitionbehavior to return the first partition if the table is multi-partitioned. Previous it would returnFalseis the table was partitioned but contained more than one partition key.† Note this improves the performance of the SQL Lab preview by including a partition predicate even though there is additional overhead of finding the latest partition. At Airbnb for a large daily partitioned table with several years of data this reduced the query time from ~ 75 seconds to ~ 3 seconds. This also helps to ensure that the data preview is associated with the partition (guaranteed for the single partitioned case) shown in the UI.
to: @graceguo-supercat @kristw @michellethomas @mistercrunch @timifasubaa @williaster