Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename onTooltip to setTooltip #6103

Merged
merged 2 commits into from
Oct 15, 2018
Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Oct 15, 2018

Follow-up from #6039 , rename onTooltip to setTooltip for all deck.gl vis components

@williaster @conglei @betodealmeida @mistercrunch

@codecov-io
Copy link

Codecov Report

Merging #6103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6103   +/-   ##
=======================================
  Coverage   77.28%   77.28%           
=======================================
  Files          47       47           
  Lines        9332     9332           
=======================================
  Hits         7212     7212           
  Misses       2120     2120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ce1b2...f41df39. Read the comment docs.

@kristw kristw changed the title rename onTooltip to setTooltip Rename onTooltip to setTooltip Oct 15, 2018
@mistercrunch
Copy link
Member

LGTM

@mistercrunch mistercrunch merged commit dc7b6f2 into apache:master Oct 15, 2018
@kristw kristw deleted the kristw-settooltip branch October 15, 2018 17:13
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* rename onTooltip to setTooltip

* fix typo

(cherry picked from commit dc7b6f2)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* rename onTooltip to setTooltip

* fix typo

(cherry picked from commit dc7b6f2)
(cherry picked from commit 86aa6b4)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* rename onTooltip to setTooltip

* fix typo

(cherry picked from commit dc7b6f2)
(cherry picked from commit 86aa6b4)
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
* rename onTooltip to setTooltip

* fix typo

(cherry picked from commit dc7b6f2)
(cherry picked from commit 86aa6b4)
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
* rename onTooltip to setTooltip

* fix typo
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants