Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[external-metadata] Fix unknown column types #6196

Merged

Conversation

john-bodley
Copy link
Member

This PR fixes an issue where the SQLAlchemy NullType() cannot be cast to a string. Similar to here the fix is merely to set the type as UNKNOWN.

to: @michellethomas @mistercrunch

@mistercrunch
Copy link
Member

LGTM

@codecov-io
Copy link

codecov-io commented Oct 26, 2018

Codecov Report

Merging #6196 into master will decrease coverage by 0.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6196      +/-   ##
==========================================
- Coverage   76.93%   76.91%   -0.02%     
==========================================
  Files          47       47              
  Lines        9389     9393       +4     
==========================================
+ Hits         7223     7225       +2     
- Misses       2166     2168       +2
Impacted Files Coverage Δ
superset/connectors/sqla/models.py 80.71% <60%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0479d5...26b3931. Read the comment docs.

@john-bodley john-bodley merged commit 71db073 into apache:master Oct 26, 2018
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 30, 2018
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants