Make stacktraces available in many more cases #6299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that since the introduction of <SuperChart />, errors in the visualization javascript (which are somewhat common and expected, especially as we'll support plugins) were not handled and the whole page would throw and go missing. Here I'm introducing a new <ErrorBoundary /> component that elegantly wraps other components and handles errors. It's inspired by: https://reactjs.org/docs/error-boundaries.html The default behavior of the component is to simply surface the error as an <Alert bsStyle="danger" /> and exposes the React stacktrace when clicking on the error. It's also possible to use component and pass an onError handler and not show the default message. This also fixes some minor bugs in TimeTable.
kristw
reviewed
Nov 8, 2018
| @@ -56,6 +56,7 @@ export default function chartReducer(charts = {}, action) { | |||
| [actions.CHART_RENDERING_FAILED](state) { | |||
| return { ...state, | |||
| chartStatus: 'failed', | |||
| chartStackTrace: action.stackTrace, | |||
There was a problem hiding this comment.
Should chartStackTrace be cleared at some point? Otherwise it will be possible to have chartStatus being successful with stale chartStackTrace from previous failure.
There was a problem hiding this comment.
Good call, even though the logic of what renders is based on chartStatus, it's a good idea to not leave expired state in Redux
Codecov Report
@@ Coverage Diff @@
## master #6299 +/- ##
==========================================
+ Coverage 77.31% 77.33% +0.01%
==========================================
Files 67 67
Lines 9575 9578 +3
==========================================
+ Hits 7403 7407 +4
+ Misses 2172 2171 -1
Continue to review full report at Codecov.
|
kristw
approved these changes
Nov 8, 2018
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* Wrap <LoadableRenderer /> with <ErrorBoundary /> It appears that since the introduction of <SuperChart />, errors in the visualization javascript (which are somewhat common and expected, especially as we'll support plugins) were not handled and the whole page would throw and go missing. Here I'm introducing a new <ErrorBoundary /> component that elegantly wraps other components and handles errors. It's inspired by: https://reactjs.org/docs/error-boundaries.html The default behavior of the component is to simply surface the error as an <Alert bsStyle="danger" /> and exposes the React stacktrace when clicking on the error. It's also possible to use component and pass an onError handler and not show the default message. This also fixes some minor bugs in TimeTable. * Addressing comments * Getting more stack traces * Adressing comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When errors occur, it's nice to have access to the stack trace in the UI. Historically some errors would show a stack trace, some wouldn't.
This PR captures many more cases where stacktraces were not captured/shown before. It builds on top of #6294 and #6220