Fix adhoc metrics in Polygon #6399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
reviewed
Nov 16, 2018
| {fd.metric && | ||
| <div>{fd.metric}: <strong>{o.object[fd.metric]}</strong></div>} | ||
| </div>); | ||
| } else if (fd.line_column && (fd.line_type === 'geohash' || fd.line_type === 'zipcode')) { |
There was a problem hiding this comment.
add fd.metric to else if condition
Is there any reason why it is separate?
hughhhh
reviewed
Nov 16, 2018
| ? parseInt(formDataNumBuckets, 10) | ||
| : 10; | ||
| const [minValue, maxValue] = extent(features, d => d[metric]); | ||
| const numBuckets = formDataNumBuckets ? parseInt(formDataNumBuckets, 10) : 10; |
There was a problem hiding this comment.
nit: Better to leave a DEFAULT_NUM_BUCKETS = 10 at the top of the file. Can we replace all the inline conditions in this file for better readability/consistency
mistercrunch
force-pushed
the
fix_metric_deck
branch
from
b55fbe4
to
e734c8b
Compare
mistercrunch
force-pushed
the
fix_metric_deck
branch
from
e734c8b
to
79ff176
Compare
Codecov Report
@@ Coverage Diff @@
## master #6399 +/- ##
=======================================
Coverage 77.31% 77.31%
=======================================
Files 67 67
Lines 9581 9581
=======================================
Hits 7408 7408
Misses 2173 2173Continue to review full report at Codecov.
|
|
Addressed comments, mergin' |
mistercrunch
added a commit
that referenced
this pull request
Nov 30, 2018
* Fix adhoc metrics in Polygon * Addressing comments (cherry picked from commit 4c94447)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* Fix adhoc metrics in Polygon * Addressing comments
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* Fix adhoc metrics in Polygon * Addressing comments (cherry picked from commit 170aaa2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<ErrorBoundary>at higher level to catch tooltip-related errors