[epoch] Remove non-UTC epoch logic #7667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7667 +/- ##
==========================================
- Coverage 73.92% 65.58% -8.35%
==========================================
Files 106 435 +329
Lines 11444 21749 +10305
Branches 0 2394 +2394
==========================================
+ Hits 8460 14264 +5804
- Misses 2984 7364 +4380
- Partials 0 121 +121
Continue to review full report at Codecov.
|
villebro
approved these changes
Jun 6, 2019
john-bodley
force-pushed
the
john-bodley--deprecate-non-utc-epoch
branch
from
e93f33b
to
f80712b
Compare
etr2460
approved these changes
Jun 6, 2019
| @@ -23,6 +23,9 @@ assists people when migrating to a new version. | |||
|
|
|||
| ## Next Version | |||
|
|
|||
| * [7667](https://github.com/apache/incubator-superset/pull/7667): a change to | |||
There was a problem hiding this comment.
nit: remove the "to" before reference
a change to make Unix (epoch) timestamps reference UTC as opposed to the local time zone.
john-bodley
force-pushed
the
john-bodley--deprecate-non-utc-epoch
branch
from
2f06959
to
d14586c
Compare
|
@agrawaldevesh are you onboard with this change? |
mistercrunch
approved these changes
Jun 11, 2019
john-bodley
force-pushed
the
john-bodley--deprecate-non-utc-epoch
branch
from
d14586c
to
6dfdde0
Compare
john-bodley
force-pushed
the
john-bodley--deprecate-non-utc-epoch
branch
2 times, most recently
from
3d290e4
to
e666244
Compare
shmsr
added a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Nov 11, 2019
PR apache#8450: Making client time use UTC as the local time PR apache#7667: Remove non-UTC epoch logic
12 tasks
shmsr
added a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Nov 11, 2019
PR apache#8450: Making client time use UTC as the local time PR apache#7667: Remove non-UTC epoch logic
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
As @agrawaldevesh correctly identified in #6721 previously we were computing the Unix timestamp for the right-hand-side (RHS) of the temporal filter condition using the local time zone as opposed to UTC which is the definition of a Unix timestamp (or epoch).
@agrawaldevesh's change was behind a feature flag and disabled by default however this clearly is a bug and I sense we should remedy the problem by merely replacing the previously incorrect logic. Note I strongly believe users were probably unaware of the issue as Unix timestamps aren't human readable.
TEST PLAN
CI.
ADDITIONAL INFORMATION
REVIEWERS
to: @agrawaldevesh @betodealmeida @michellethomas @mistercrunch @villebro