[297] Refactor config classes #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job! |
ashvina
reviewed
Aug 2, 2024
xtable-api/src/main/java/org/apache/xtable/conversion/ExternalTable.java
Show resolved
Hide resolved
ashvina
reviewed
Aug 2, 2024
xtable-api/src/main/java/org/apache/xtable/conversion/ExternalTable.java
Outdated
Show resolved
Hide resolved
ashvina
reviewed
Aug 2, 2024
xtable-api/src/main/java/org/apache/xtable/conversion/TableSyncConfig.java
Outdated
Show resolved
Hide resolved
ashvina
reviewed
Aug 2, 2024
xtable-api/src/main/java/org/apache/xtable/conversion/TableSyncConfig.java
Outdated
Show resolved
Hide resolved
ashvina
reviewed
Aug 5, 2024
| ? null | ||
| : table.getNamespace().split("\\.")) | ||
| .catalogConfig(icebergCatalogConfig) | ||
| .formatName(tableFormat) |
There was a problem hiding this comment.
Set .additionalProperties(targetProperties)
There was a problem hiding this comment.
There is no targetProperties currently, what should this contain?
ashvina
reviewed
Aug 5, 2024
| .tableName(table.getTableName()) | ||
| Properties sourceProperties = new Properties(); | ||
| if (table.getPartitionSpec() != null) { | ||
| sourceProperties.put( |
There was a problem hiding this comment.
nit: This property should be needed required if the sourceFormat is Hudi
There was a problem hiding this comment.
it's not required if the table is non-partitioned. I have another set of changes to remove the need for this config altogether that I can open source in the future
ashvina
approved these changes
Aug 5, 2024
the-other-tim-brown
force-pushed
the
297-properties-based-config-2
branch
from
02bff5c
to
3159009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Aims to address #297
Brief change log
Map<String, String>of client properties when initializing the source client (can be done for target client's as well if there is need) which may contain other parameters required by a specific client that are not common to multiple formats.PerTableConfiginto aSourceTable,TargetTable, andTableSyncConfigto decouple the sync specifics from the table configurationsHudiSourceConfigis now derived from the client propertiesMap<String, String>Verify this pull request