Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stopping cn leader stuck when region region migration #14175

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

OneSizeFitsQuorum
Copy link
Contributor

get out of the loop when encounter InterruptedException

Signed-off-by: OneSizeFitQuorum <tanxinyu@apache.org>
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Collaborator

@HxpSerein HxpSerein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wangchao316 wangchao316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.64%. Comparing base (4edc42b) to head (b1de193).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...onfignode/procedure/env/RegionMaintainHandler.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14175      +/-   ##
============================================
+ Coverage     39.62%   39.64%   +0.02%     
  Complexity       71       71              
============================================
  Files          4224     4230       +6     
  Lines        269427   269598     +171     
  Branches      32659    32681      +22     
============================================
+ Hits         106747   106877     +130     
- Misses       162680   162721      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit 9b22f7c into master Nov 22, 2024
30 of 34 checks passed
@OneSizeFitsQuorum OneSizeFitsQuorum deleted the stop_cn_leader_stuck branch November 22, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants