-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: MetadataShell should handle ProducerIdsRecord #11603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61478ad
to
5b88573
Compare
5b88573
to
443ae26
Compare
hachikuji
reviewed
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch. Left a couple suggestions for consideration.
shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java
Outdated
Show resolved
Hide resolved
shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java
Outdated
Show resolved
Hide resolved
2d65c5a
to
aaff953
Compare
mimaison
reviewed
Feb 10, 2022
shell/src/test/java/org/apache/kafka/shell/MetadataNodeManagerTest.java
Outdated
Show resolved
Hide resolved
hachikuji
reviewed
Feb 10, 2022
shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java
Outdated
Show resolved
Hide resolved
hachikuji
reviewed
Feb 11, 2022
shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java
Outdated
Show resolved
Hide resolved
25b1959
to
e7c832c
Compare
hachikuji
approved these changes
Feb 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the patch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description of your change
We store producer IDs in broker snapshots in #11527, I think we could also add the ability to inspect it using MetadataShell.
Summary of testing strategy (including rationale)
I tested this locally:
Committer Checklist (excluded from commit message)