From ee4dc70e680de110360bcfcfc2c067961db1c611 Mon Sep 17 00:00:00 2001 From: Binbin Date: Thu, 6 Jul 2023 16:34:27 +0800 Subject: [PATCH] Remove debug server logs These logs were there in the earliest days, i guess they are for debug, remove them now to avoid polluting the server logs. The blpop one is easy to reproduce: ``` Failed to execute redis command: blpop, err: Invalid argument: WRONGTYPE Operation against a key holding the wrong kind of value ``` Checked the relevant LOG calls and fix a typo. --- src/cluster/replication.cc | 2 +- src/commands/cmd_list.cc | 2 -- src/commands/cmd_stream.cc | 2 -- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/cluster/replication.cc b/src/cluster/replication.cc index f5c3550af39..39a2ade7c2c 100644 --- a/src/cluster/replication.cc +++ b/src/cluster/replication.cc @@ -116,7 +116,7 @@ void FeedSlaveThread::loop() { auto batch = iter_->GetBatch(); if (batch.sequence != curr_seq) { LOG(ERROR) << "Fatal error encountered, WAL iterator is discrete, some seq might be lost" - << ", sequence " << curr_seq << " expectd, but got " << batch.sequence; + << ", sequence " << curr_seq << " expected, but got " << batch.sequence; Stop(); return; } diff --git a/src/commands/cmd_list.cc b/src/commands/cmd_list.cc index f4ccba353e9..15e6652d552 100644 --- a/src/commands/cmd_list.cc +++ b/src/commands/cmd_list.cc @@ -234,8 +234,6 @@ class CommandBPop : public Commander, } } else if (!s.IsNotFound()) { conn_->Reply(redis::Error("ERR " + s.ToString())); - LOG(ERROR) << "Failed to execute redis command: " << conn_->current_cmd->GetAttributes()->name - << ", err: " << s.ToString(); } return s; diff --git a/src/commands/cmd_stream.cc b/src/commands/cmd_stream.cc index 9816548f146..9265e90ba66 100644 --- a/src/commands/cmd_stream.cc +++ b/src/commands/cmd_stream.cc @@ -742,8 +742,6 @@ class CommandXRead : public Commander, auto s = stream_db.Range(streams_[i], options, &result); if (!s.ok()) { conn_->Reply(redis::MultiLen(-1)); - LOG(ERROR) << "ERR executing XRANGE for stream " << streams_[i] << " from " << ids_[i].ToString() << " to " - << options.end.ToString() << " with count " << count_ << ": " << s.ToString(); } if (result.size() > 0) {