Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CLI arguments/environment variables to overwrite conf file values #1034

Closed
1 of 2 tasks
kesavkolla opened this issue Oct 24, 2022 · 2 comments · Fixed by #1037
Closed
1 of 2 tasks
Assignees
Labels
enhancement type enhancement feature type new feature help wanted Good for newcomers

Comments

@kesavkolla
Copy link

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

It will be good idea to support some configuration overwrites via CLI arguments or Environment variables. Specially it will be so much useful in containerized environment. We can pack the default conf file in the docker image and overwrite respective values by setting environment variables or CLI args.

Solution

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@kesavkolla kesavkolla added the enhancement type enhancement label Oct 24, 2022
@git-hulk
Copy link
Member

git-hulk commented Oct 24, 2022

Yes, it makes a lot sense to support overriding configurations through passing environments.

@git-hulk git-hulk added help wanted Good for newcomers feature type new feature labels Oct 24, 2022
@PragmaTwice
Copy link
Member

I will try to implement it when I am free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement feature type new feature help wanted Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants