New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support transcation processing for `cluster setslot` #1439

Open

1 of 2 tasks

infdahai opened this issue May 14, 2023 · 4 comments

Open

1 of 2 tasks

support transcation processing for `cluster setslot` #1439

infdahai opened this issue May 14, 2023 · 4 comments

Labels

Contributor

infdahai commented May 14, 2023 •

edited

Loading

Search before asking

I had searched in the issues and found no similar issues.

Motivation

Originally posted by @infdahai in #1414 (comment)

Cluster::SetSlotRanges exists consistency issues if slot in the middle is down
https://github.com/apache/incubator-kvrocks/blob/d2d10f7dd220992a2c7cf9f1b44a96a6c6ac80a7/src/cluster/cluster.cc#L123-L145

Solution

Are you willing to submit a PR?

I'm willing to submit a PR!

The text was updated successfully, but these errors were encountered:

infdahai added the enhancement label

Contributor Author

infdahai commented Jun 18, 2023

BTW, two places exist in cluster.cc. We should find a solution to delete all the range in a write batch.

ameya-deshmukh commented Sep 6, 2023

@infdahai is this still relevant?

Member

git-hulk commented Sep 7, 2023

@ameya-deshmukh Yes, would you like to take this?

ameya-deshmukh commented Sep 7, 2023

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment