Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for stream consumer group #2478

Closed
1 of 2 tasks
Yangsx-1 opened this issue Aug 8, 2024 · 8 comments
Closed
1 of 2 tasks

Add more tests for stream consumer group #2478

Yangsx-1 opened this issue Aug 8, 2024 · 8 comments
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers

Comments

@Yangsx-1
Copy link
Contributor

Yangsx-1 commented Aug 8, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

We should add more test cases for stream consumer group, especially for the time related information such as idle time and inactive time, and other information in XINFO command.

Solution

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@Yangsx-1 Yangsx-1 added enhancement type enhancement help wanted Good for newcomers good first issue Good for newcomers labels Aug 8, 2024
@jonathanc-n
Copy link
Contributor

@PragmaTwice @git-hulk What is the syntax for isolating go tests for testing?

@jonathanc-n
Copy link
Contributor

jonathanc-n commented Sep 12, 2024

@Yangsx-1 Are there any tests you would like to add in particular? Checking certain functionality?

@git-hulk
Copy link
Member

@PragmaTwice @git-hulk What is the syntax for isolating go tests for testing?

What do you mean by isolating go tests? Are you asking how to run the specified test cases?

@jonathanc-n
Copy link
Contributor

@git-hulk Yes, specified test cases.

@Yangsx-1
Copy link
Contributor Author

@Yangsx-1 Are there any tests you would like to add in particular? Checking certain functionality?

I think we should pay attention to time related variables, such as idel time and inactive time in XINFO CONSUMERS, and some counter variables such as pending number, last_delivered_id, entries_read, lag and so on.

@Yangsx-1
Copy link
Contributor Author

@git-hulk Yes, specified test cases.

You can run command like this: ./x.py test go ./build -run ^TestStreamOffset$ github.com/apache/incubator-kvrocks/tests/gocase/unit/type/stream -v, and you can change TestStreamOffset when you want to test other go functions.

@git-hulk
Copy link
Member

@git-hulk Yes, specified test cases.

You can run with -test.run. For example, I want to run the test case TestFullSyncReplication, then you should enter the dir tests/gocase/integration/replication and run go test -test.run "TestFullSyncReplication" -workspace /tmp -binPath {Your Kvrocks Binary Path}.

Remember to replace {Your Kvrocks Binary Path} with your owner Kvrocks binary path.

@jonathanc-n
Copy link
Contributor

@Yangsx-1 @git-hulk Thank you guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants