[MSHARED-1158] make DependencyCollectorBuilder more configurable #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
force-pushed
the
MSHARED-1158-DefaultDependencyCollectorBuilder-configurable
branch
from
8d42b77
to
a8b40f5
Compare
olamy
commented
Nov 8, 2022
| new DirectScopeDependencySelector( JavaScopes.TEST ), | ||
| new DirectScopeDependencySelector( JavaScopes.PROVIDED ), | ||
| new OptionalDependencySelector(), | ||
| new ExclusionDependencySelector() ); |
There was a problem hiding this comment.
well TBH this empty ExclusionDependencySelector doesn't have any effect. we could simply remove it and the code not will not pass tru to do nothing :)
src/main/java/org/apache/maven/shared/dependency/graph/DependencyCollectorRequest.java
Show resolved
Hide resolved
Yup but should be part of another change? |
Signed-off-by: Olivier Lamy <olamy@apache.org>
slawekjaranowski
approved these changes
Nov 8, 2022
olamy
deleted the
MSHARED-1158-DefaultDependencyCollectorBuilder-configurable
branch
olamy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MSHARED-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MSHARED-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.