-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MJAR-278] Update plugin (requires Maven 3.2.5+) #19
Conversation
And retain it still Java7. Make mvn core bits proper scoped.
<mavenArchiverVersion>3.5.0</mavenArchiverVersion> | ||
<mavenVersion>3.1.0</mavenVersion> | ||
<mavenArchiverVersion>3.5.1</mavenArchiverVersion> | ||
<mavenVersion>3.2.5</mavenVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as on war. Is the projct ready to drop 3.1.1 support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is requirement dictated by maven-plugin-testing-harness v 3.3.0
Any idea about failing IT |
Try rebase, see #40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be rebased with master
pom.xml
Outdated
<dependency> | ||
<groupId>org.codehaus.plexus</groupId> | ||
<artifactId>plexus-archiver</artifactId> | ||
<version>4.2.5</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be needed since when the maven-archiver 3.6.0 is released (#43) it will update plexus-archiver to 4.3.0, so the explicit dependency should not be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but I have to, as am dropping m-shared-utils... so IMHO once this merged you should add your PR on top of it. W/o this change, due drop of m-shared-utils the build would fail 😞
Depends on apache/maven-file-management#11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until File Management 3.1.0 is released.
I see these:
I think at least Plexus Utils can go away, no? |
Jenkins windows node failure (post build, build is OK): clean workspace |
Bump to Java 8. Make mvn core bits
proper scoped.
https://issues.apache.org/jira/browse/MJAR-278