Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJAR-278] Update plugin (requires Maven 3.2.5+) #19

Merged
merged 7 commits into from
Jul 2, 2022
Merged

[MJAR-278] Update plugin (requires Maven 3.2.5+) #19

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
21716f5
Update plugin
cstamas Oct 11, 2021
e984eb7
Merge remote-tracking branch 'origin/master' into update-plugin
cstamas Apr 14, 2022
f8ed4a5
Update parent
cstamas Apr 14, 2022
19998f4
Merge remote-tracking branch 'origin/master' into update-plugin
cstamas Jun 27, 2022
2665f79
Update bits to not require m-shared-util
cstamas Jun 27, 2022
19e651f
Set released version
cstamas Jul 2, 2022
9d1833a
Drop p-u
cstamas Jul 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
<parent>
<artifactId>maven-plugins</artifactId>
<groupId>org.apache.maven.plugins</groupId>
<version>34</version>
<relativePath>../../pom/maven/maven-plugins/pom.xml</relativePath>
<version>35</version>
</parent>

<artifactId>maven-jar-plugin</artifactId>
Expand Down Expand Up @@ -77,7 +76,7 @@
<properties>
<mavenFileManagementVersion>3.0.0</mavenFileManagementVersion>
<mavenArchiverVersion>3.5.2</mavenArchiverVersion>
<mavenVersion>3.1.0</mavenVersion>
<mavenVersion>3.2.5</mavenVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as on war. Is the projct ready to drop 3.1.1 support?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is requirement dictated by maven-plugin-testing-harness v 3.3.0

<javaVersion>7</javaVersion>
<project.build.outputTimestamp>2022-01-08T21:19:21Z</project.build.outputTimestamp>
</properties>
Expand All @@ -87,16 +86,19 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.shared</groupId>
Expand Down Expand Up @@ -130,7 +132,11 @@
<groupId>org.apache.maven.shared</groupId>
<artifactId>maven-shared-utils</artifactId>
<version>3.3.4</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-archiver</artifactId>
<version>4.2.5</version>
Copy link
Contributor

@jorsol jorsol Jun 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed since when the maven-archiver 3.6.0 is released (#43) it will update plexus-archiver to 4.3.0, so the explicit dependency should not be added.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I have to, as am dropping m-shared-utils... so IMHO once this merged you should add your PR on top of it. W/o this change, due drop of m-shared-utils the build would fail 😞

</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
Expand All @@ -147,7 +153,7 @@
<dependency>
<groupId>org.apache.maven.plugin-testing</groupId>
<artifactId>maven-plugin-testing-harness</artifactId>
<version>3.1.0</version>
<version>3.3.0</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down