Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPOM-348] Drop configuration for not used Maven Changes Plugin #81

Merged
merged 1 commit into from
Oct 26, 2022
Merged

[MPOM-348] Drop configuration for not used Maven Changes Plugin #81

merged 1 commit into from
Oct 26, 2022

Conversation

slachiewicz
Copy link
Member

No description provided.

@olamy
Copy link
Member

olamy commented Oct 16, 2022

after this change, I wonder if Create an announcement. section from here section will still work?
@hboutemy ?

@michael-o
Copy link
Member

after this change, I wonder if Create an announcement. section from here section will still work? @hboutemy ?

Likely not. Personally, I have never used the Maven Changes Plugin for this.

@olamy
Copy link
Member

olamy commented Oct 17, 2022

after this change, I wonder if Create an announcement. section from here section will still work? @hboutemy ?

Likely not. Personally, I have never used the Maven Changes Plugin for this.

me neither :) but as it's part of the documentation.

gnodet
gnodet approved these changes Oct 23, 2022
View reviewed changes
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the plugin is not used, I'm fine with the removal, but the doc should definitely be updated so that the related section is removed.
I'm planning a MAVEN-38 release next week, should that be included ?

@gnodet gnodet mentioned this pull request Oct 24, 2022
Merged
@slachiewicz slachiewicz merged commit e98652c into master Oct 26, 2022
@slachiewicz slachiewicz deleted the MPOM-348 branch October 26, 2022 17:15
@olamy
Copy link
Member

olamy commented Nov 19, 2022

@slachiewicz as asked in a previous comment please update the release process documentation here https://maven.apache.org/developers/release/maven-project-release-procedure.html as Create an announcement with using maven-changes-plugin will certainly not work anymore with this change.

@olamy
Copy link
Member

olamy commented Nov 27, 2022

@slachiewicz ping please fix documentation!

@slachiewicz
Copy link
Member Author

done apache/maven-site@9bb7315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnodet gnodet gnodet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slachiewicz @olamy @michael-o @gnodet