diff --git a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java index bb787771..c49fb5b2 100644 --- a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java +++ b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java @@ -950,21 +950,19 @@ protected CloseableHttpResponse execute( HttpUriRequest httpMethod ) requestConfigBuilder.setProxy( proxy ); } - HttpMethodConfiguration config = - httpConfiguration == null ? null : httpConfiguration.getMethodConfiguration( httpMethod ); + requestConfigBuilder.setConnectTimeout( getTimeout() ); + requestConfigBuilder.setSocketTimeout( getReadTimeout() ); + if ( httpMethod instanceof HttpPut ) + { + requestConfigBuilder.setExpectContinueEnabled( true ); + } + HttpMethodConfiguration config = + httpConfiguration == null ? null : httpConfiguration.getMethodConfiguration( httpMethod ); if ( config != null ) { ConfigurationUtils.copyConfig( config, requestConfigBuilder ); } - else - { - requestConfigBuilder.setSocketTimeout( getReadTimeout() ); - if ( httpMethod instanceof HttpPut ) - { - requestConfigBuilder.setExpectContinueEnabled( true ); - } - } HttpClientContext localContext = HttpClientContext.create(); localContext.setCredentialsProvider( credentialsProvider ); diff --git a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/ConfigurationUtils.java b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/ConfigurationUtils.java old mode 100755 new mode 100644 index 0a1320a5..5214739e --- a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/ConfigurationUtils.java +++ b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/ConfigurationUtils.java @@ -61,14 +61,9 @@ public class ConfigurationUtils public static void copyConfig( HttpMethodConfiguration config, RequestConfig.Builder builder ) { - if ( config.getConnectionTimeout() > 0 ) - { - builder.setConnectTimeout( config.getConnectionTimeout() ); - } - if ( config.getReadTimeout() > 0 ) - { - builder.setSocketTimeout( config.getReadTimeout() ); - } + builder.setConnectTimeout( config.getConnectionTimeout() ); + builder.setSocketTimeout( config.getReadTimeout() ); + Properties params = config.getParams(); if ( params != null ) { diff --git a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HttpConfiguration.java b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HttpConfiguration.java index 0a8652c2..97d4d533 100644 --- a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HttpConfiguration.java +++ b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HttpConfiguration.java @@ -19,9 +19,6 @@ * under the License. */ -import org.apache.http.client.methods.HttpGet; -import org.apache.http.client.methods.HttpHead; -import org.apache.http.client.methods.HttpPut; import org.apache.http.client.methods.HttpUriRequest; /** @@ -30,9 +27,6 @@ public class HttpConfiguration { - private static final HttpMethodConfiguration DEFAULT_PUT = - new HttpMethodConfiguration().addParam( "http.protocol.expect-continue", "%b,true" ); - private HttpMethodConfiguration all; private HttpMethodConfiguration get; @@ -87,20 +81,17 @@ public HttpConfiguration setHead( HttpMethodConfiguration head ) public HttpMethodConfiguration getMethodConfiguration( HttpUriRequest method ) { - if ( method instanceof HttpGet ) + switch ( method.getMethod() ) { + case "GET": return ConfigurationUtils.merge( all, get ); - } - else if ( method instanceof HttpPut ) - { - return ConfigurationUtils.merge( DEFAULT_PUT, all, put ); - } - else if ( method instanceof HttpHead ) - { + case "PUT": + return ConfigurationUtils.merge( all, put ); + case "HEAD": return ConfigurationUtils.merge( all, head ); + default: + return all; } - - return all; } }