-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/replace plexus abstract log enabled with slf4j #1917
Refactor/replace plexus abstract log enabled with slf4j #1917
Conversation
Use this link to re-run the recipe: https://app.moderne.io/builder/aJoMKBdaq?organizationId=ZTY0ODBjZGQtMTIyOC00MzA4LTlhZmQtODM2ZmYxOWFjNzM2 Co-authored-by: Moderne <team@moderne.io>
Thanks for the quick review! Looks to have been a one off failure in CI:
|
What's the benefits of refactoring deprecated classes ? |
Hmm; you're right. I only just now noticed all of the classes here are in I did already have my eye on completely removing |
Many of our "deprecated" classes are still in active use. |
I'd closed the PR before seeing this comment; I'll leave the branch up in case you'd want to reopen and merge still. |
|
As seen on https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=181305684#MavenEcosystemCleanup-DropPlexusContainerforJSR-330+SisuGuiceextension
-Leverages openrewrite/rewrite-apache#41
This was the last one of this series; wasn't too sure about removal of
extends AbstractLogEnabled
from the deprecated classes; applied now to the classes that were not explicitly backwards compatibility tests, and retained in the two cases that were.@elharo could you also look over this last one? That would mostly conclude the removal except where not yet possible.