This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

test_loss.test_huber_loss has fixed seed that can mask flakiness #11696

Closed

szha opened this issue Jul 13, 2018 · 1 comment

Labels

Member

szha commented Jul 13, 2018

The unit test in title have been using fixed seed to mask flakiness. Suggested action:

Evaluate whether the test is flaky without fixed seed. If not, remove seed. Else move to 2
If test is flaky, determine whether it's an actual uncaught edge case. If so, fix the operator. Else move to 3
If numerical instability is inevitable, adjust tolerance level appropriately.

szha added Test Flaky labels

Contributor

apeforest commented Jul 13, 2018

Thanks for filing this issue. We will investigate this Flaky test

vdantu mentioned this issue

Remove fixed seed for test_huber_loss test #12169

Merged

7 tasks

marcoabreu closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.