-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[WIP] Windows dev environment configuration, update install instructions from source in the docs. #17206
Conversation
@mxnet-label-bot add [pr-awaiting-review] |
😴 |
e1d0c15
to
fa4641d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm besides nits.
I'd prefer if someone else could review the docs changes
@@ -0,0 +1,4 @@ | |||
psutil | |||
boto3 | |||
python-jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you added it, is it in the slave scripts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well yeah it's used as part of the Autoconnect script. But since you are recommending this for users to install, it seems a bit out of place. We should handle infrastructure and MXNet related things separately if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove it in the future, it doesn't hurt there now, and I don't want additional scripts as of now. I don't think this is a big concern, even though you are right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues...
f862851
to
4642f91
Compare
0a3e40e
to
9c9052b
Compare
…missing kernel32.lib
Work around compiler running out of heap.
Co-Authored-By: Aaron Markham <markhama@amazon.com>
…ot picked up (mingw or gcc is picked up instead)
9d9e0ab
to
12f3c9e
Compare
Description
Update windows build from source documentation with automated scripts.
As part of fixing the windows CI AMI, the scripts to setup the build environment are referenced from the documentation for ease of use.
With this PR seting up the environment in windows consists of executing just a powershell script
Together with
ci/build_windows.py
this makes 2 commands to build MXNet in a clean windows install.Before the process to setup the required environment required tons of manual and error prone install and steps.
Chance Bair is also co-author of the installation script.
Verified that the updated instructions lead to a working MXNet build:
@aaronmarkham @leezu @Chancebair