Fix OOZIE-3620: hadoopId is not sent to listener for workflow action events #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please upload PR into Oozie jira website. Thanks. |
zuston
reviewed
May 17, 2021
| @@ -85,6 +85,7 @@ protected void generateEvent(WorkflowActionBean wfAction, String wfUser) { | |||
| wfAction.getStatus(), wfUser, wfAction.getName(), wfAction.getStartTime(), wfAction.getEndTime()); | |||
| event.setErrorCode(wfAction.getErrorCode()); | |||
| event.setErrorMessage(wfAction.getErrorMessage()); | |||
| event.setHadoopId(wfAction.getExternalId()); | |||
There was a problem hiding this comment.
Actually externalId is not hadoop id. Right?
There was a problem hiding this comment.
I had checked in our Oozie database & they seemed to match.
Do you think that is incorrect? How can I fetch HadoopId then?
|
Thank you for the suggestion @zuston I had added a patch to Jira but it was failing earlier so I created this PR. It seems to be accepted by JIRA now when I re-uploaded it again. Would you suggest me to close this PR? How will the review process of my patch happen in that case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/OOZIE-3620
Not sure if you accept PRs yet or if my JIRA patch is the right way to do it.