Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Integration tests for C bindings #2250

Closed
xyjixyjixyji opened this issue May 10, 2023 · 4 comments
Closed

ci: Integration tests for C bindings #2250

xyjixyjixyji opened this issue May 10, 2023 · 4 comments

Comments

@xyjixyjixyji
Copy link
Contributor

We do not have integration tests for C bindings right now, we can implement that after we support GTest on it.

Related #2185
@Xuanwo
Copy link
Member

Xuanwo commented May 10, 2023

I think it's worth to make sure the build succeed before we setup tests.

@xyjixyjixyji
Copy link
Contributor Author

xyjixyjixyji commented May 10, 2023 •
edited
Loading

I think it's worth to make sure the build succeed before we setup tests.

Definitely, but I think maybe the build and tests should reside in the same github action?

@suyanhanx
Copy link
Member

You may take other bindings' config files as a reference. Generally, build and test are consecutive steps.

@xyjixyjixyji
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Xuanwo @suyanhanx @xyjixyjixyji