Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service: Add scp support #2643

Closed
Xuanwo opened this issue Jul 14, 2023 · 7 comments
Closed

service: Add scp support #2643

Xuanwo opened this issue Jul 14, 2023 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Jul 14, 2023

It's possible for OpenDAL to read/write data via scp over ssh. This issue seems cool for users who want to connect a ssh server and read/write data between them.

@Xuanwo Xuanwo added the help wanted Extra attention is needed label Jul 14, 2023
@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 14, 2023

Cc @NobodyXu and @silver-ymz for ideas. Can we use openssh for this task? Are there any obstacles preventing us from doing so?

@NobodyXu
Copy link
Contributor

Can we use openssh for this task? Are there any obstacles preventing us from doing so?

I'm not familiar with scp but it should be possible.

Though it should be noted that it is already deprecated.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 14, 2023

Though it should be noted that it is already deprecated.

Do you mean scp is already deprecated? Or others?

@silver-ymz
Copy link
Member

SCP is designed for single file transfers, which doesn't maintain a continuous interactive session like SFTP. As result, it will exist following problems.

  • We must build SCP session for each transfer. Although openssh provides ControlMaster feature to reduce the cost of building ssh session, SCP performance will be much lower than SFTP
  • SCP doesn't support transferring ranges of data within a file or metadata. We can only implement basic read/write operation.

I'd like to complete this feature. However, I am currently undergoing military training at school. Maybe, I can begin to complete it in next weekend.

@silver-ymz
Copy link
Member

silver-ymz commented Jul 14, 2023

SCP is already deperated by openssh community due to many security issues, like CVE-2019-6111, CVE-2020-15778. Please see the detailed report here. https://lwn.net/Articles/835962/

Since OpenSSH 8.8, scp has use the SFTP protocol for transfers by default.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 14, 2023

Got it, seems we don't a separate scp service anymore

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 14, 2023

Thank you all for the advice and research!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants