From 533b38753ea20b5403a0d3a203690a1b3f98f2ba Mon Sep 17 00:00:00 2001
From: "Doroszlai, Attila" <adoroszlai@apache.org>
Date: Fri, 15 Nov 2024 15:37:55 +0100
Subject: [PATCH 1/3] HDDS-11719. Remove dependency on server components from
 ozonefs-common

---
 hadoop-ozone/ozonefs-common/pom.xml | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/hadoop-ozone/ozonefs-common/pom.xml b/hadoop-ozone/ozonefs-common/pom.xml
index 2b79beae35e..20df0d215e2 100644
--- a/hadoop-ozone/ozonefs-common/pom.xml
+++ b/hadoop-ozone/ozonefs-common/pom.xml
@@ -112,35 +112,15 @@
     </dependency>
 
     <!-- Test dependencies -->
-    <dependency>
-      <groupId>org.apache.ozone</groupId>
-      <artifactId>hdds-container-service</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.apache.ozone</groupId>
       <artifactId>hdds-hadoop-dependency-test</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.apache.ozone</groupId>
-      <artifactId>hdds-server-framework</artifactId>
-      <scope>test</scope>
-    </dependency>
-    <dependency>
-      <groupId>org.apache.ozone</groupId>
-      <artifactId>hdds-server-scm</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.apache.ozone</groupId>
       <artifactId>hdds-test-utils</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.apache.ozone</groupId>
-      <artifactId>ozone-manager</artifactId>
-      <scope>test</scope>
-    </dependency>
   </dependencies>
 </project>

From 2c474fa5c57f3a1654f3ec013adfd11847a37330 Mon Sep 17 00:00:00 2001
From: "Doroszlai, Attila" <adoroszlai@apache.org>
Date: Fri, 15 Nov 2024 17:01:36 +0100
Subject: [PATCH 2/3] OzoneFsShell depends on commons-cli, but is getting it
 only accidentally (by using ozone-tools module classpath at runtime)

---
 hadoop-hdds/hadoop-dependency-client/pom.xml             | 5 +----
 .../org/apache/hadoop/fs/ozone/TestOzoneFsShell.java     | 9 ++++-----
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/hadoop-hdds/hadoop-dependency-client/pom.xml b/hadoop-hdds/hadoop-dependency-client/pom.xml
index 489e1b3ddf5..7676f1f45f1 100644
--- a/hadoop-hdds/hadoop-dependency-client/pom.xml
+++ b/hadoop-hdds/hadoop-dependency-client/pom.xml
@@ -59,10 +59,7 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd">
           <groupId>com.google.guava</groupId>
           <artifactId>guava</artifactId>
         </exclusion>
-        <exclusion>
-          <groupId>commons-cli</groupId>
-          <artifactId>commons-cli</artifactId>
-        </exclusion>
+        <!-- commons-cli is required by OzoneFsShell -->
         <exclusion>
           <groupId>org.apache.commons</groupId>
           <artifactId>commons-math3</artifactId>
diff --git a/hadoop-ozone/ozonefs-common/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFsShell.java b/hadoop-ozone/ozonefs-common/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFsShell.java
index a15da5228f3..96506933952 100644
--- a/hadoop-ozone/ozonefs-common/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFsShell.java
+++ b/hadoop-ozone/ozonefs-common/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFsShell.java
@@ -22,7 +22,6 @@
 import org.apache.hadoop.util.ToolRunner;
 
 import java.io.ByteArrayOutputStream;
-import java.io.IOException;
 import java.io.PrintStream;
 import java.util.Arrays;
 
@@ -32,7 +31,6 @@
 
 import org.junit.jupiter.api.Test;
 
-
 /**
  * Tests the behavior of OzoneFsShell.
  */
@@ -40,7 +38,7 @@ public class TestOzoneFsShell {
 
   // tests command handler for FsShell bound to OzoneDelete class
   @Test
-  public void testOzoneFsShellRegisterDeleteCmd() throws IOException {
+  public void testOzoneFsShellRegisterDeleteCmd() throws Exception {
     final String rmCmdName = "rm";
     final String rmCmd = "-" + rmCmdName;
     final String arg = "arg1";
@@ -52,16 +50,17 @@ public void testOzoneFsShellRegisterDeleteCmd() throws IOException {
     System.setErr(bytesPrintStream);
     try {
       ToolRunner.run(shell, argv);
-    } catch (Exception e) {
-    } finally {
+
       // test command bindings for "rm" command handled by OzoneDelete class
       CommandFactory factory = shell.getCommandFactory();
+      assertNotNull(factory);
       assertEquals(1, Arrays.stream(factory.getNames())
           .filter(c -> c.equals(rmCmd)).count());
       Command instance = factory.getInstance(rmCmd);
       assertNotNull(instance);
       assertEquals(OzoneFsDelete.Rm.class, instance.getClass());
       assertEquals(rmCmdName, instance.getCommandName());
+    } finally {
       shell.close();
       System.setErr(oldErr);
     }

From aa87b843fac8915eed33151e86bf9f4a0b5df53c Mon Sep 17 00:00:00 2001
From: "Doroszlai, Attila" <adoroszlai@apache.org>
Date: Wed, 4 Dec 2024 06:07:27 +0100
Subject: [PATCH 3/3] remove hdds-test-utils

---
 hadoop-ozone/ozonefs-common/pom.xml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/hadoop-ozone/ozonefs-common/pom.xml b/hadoop-ozone/ozonefs-common/pom.xml
index 20df0d215e2..18839deaee5 100644
--- a/hadoop-ozone/ozonefs-common/pom.xml
+++ b/hadoop-ozone/ozonefs-common/pom.xml
@@ -117,10 +117,5 @@
       <artifactId>hdds-hadoop-dependency-test</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.apache.ozone</groupId>
-      <artifactId>hdds-test-utils</artifactId>
-      <scope>test</scope>
-    </dependency>
   </dependencies>
 </project>