readme: Fix build instructions (wrong protobuf version) #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costimuraru
reviewed
May 19, 2018
README.md
Outdated
| tar xzf protobuf-2.5.0.tar.gz | ||
| cd protobuf-2.5.0 | ||
| wget https://github.com/google/protobuf/archive/v3.2.0.tar.gz | ||
| tar xzf protobuf-3.2.0.tar.gz |
There was a problem hiding this comment.
Should this line be tar xzf v3.2.0.tar.gz?
Other than that +1
The project fails to build with Protobuf 2.5.0. Signed-off-by: George Gaydarov <git@gg7.io>
costimuraru
approved these changes
May 19, 2018
|
@gg7 Already fixed. Do you mind close it? |
|
@wangyum Sure. I'm glad this got fixed after 6 months :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis uses Protobuf 3.2.0 for testing, but the readme specifies Protobuf 2.5.0.
The project fails to build with 2.5.0:
The issue is very easy to reproduce with my Dockerfile -- gg7/docker-parquet-mr (note that you have to change the protobuf URL in addition to specifying
--build-arg PROTOBUF_VERSION=2.5.0due to protocolbuffers/protobuf#2025 ).