Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flow.onErrorComplete operator #624

Closed
pjfanning opened this issue Sep 2, 2023 Discussed in #623 · 5 comments
Closed

Add Flow.onErrorComplete operator #624

pjfanning opened this issue Sep 2, 2023 Discussed in #623 · 5 comments
Assignees
Milestone

Comments

@pjfanning
Copy link
Contributor

Discussed in #623

Originally posted by He-Pin September 2, 2023
When we encounter an exception, sometime we may don't want the flow to result in an error but completes normally.

The implementation can be simple, but still cause some confusing.

I would like suggest to add a onErrorComplete operator which will complete the flow on some dedicated condition.

And better we have another onErrorContiune operator, which will keep the flow working but will need the operator before it to support this.

@nvollmar
Copy link
Contributor

nvollmar commented Sep 4, 2023

Maybe we could lean the design on the akka.actor.SupervisorStrategy having a decider that returns Fail, Complete or Continue

@He-Pin
Copy link
Member

He-Pin commented Sep 19, 2023

@nvollmar That's a good idea.

@He-Pin He-Pin self-assigned this Jan 4, 2024
@He-Pin He-Pin added this to the 1.1.0 milestone Jan 4, 2024
@He-Pin
Copy link
Member

He-Pin commented Jan 4, 2024

@nvollmar I'm planning to handle this this weekend, onething I have in mind is we can have something like the reactor-core's operator name, which is very easy to use and accessiable. so I would like to continue with onErrorComplete name, and I mostly using Javadsl.

Your proposal is generic and great .

@nvollmar
Copy link
Contributor

nvollmar commented Jan 5, 2024

I'm back home, so I'd be available for a review, just request me on the PR

@He-Pin
Copy link
Member

He-Pin commented Jan 7, 2024

In spring-projects/spring-framework#31352 which split the usage of onErrorResume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants