Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIP-119: Enable consistent hashing by default on KeyShared dispatcher #13305

Closed
merlimat opened this issue Dec 14, 2021 · 1 comment · Fixed by #13352
Closed

PIP-119: Enable consistent hashing by default on KeyShared dispatcher #13305

merlimat opened this issue Dec 14, 2021 · 1 comment · Fixed by #13352
Assignees
Labels

Comments

@merlimat
Copy link
Contributor

Motivation

The consistent hashing implementation to uniformly assign keys to consumers
in the context of a KeyShared subscription, was introduced in
#6791, which was released in Pulsar 2.6.0.

While consistent hashing can use slightly more memory in certain cases, it is
more suitable as a general default implementation, as it leads to a fairer
distribution of keys across consumers, and avoiding corner cases that depend
on the sequence of addition/removal of consumers.

Proposed changes

In 2.10 release, for the setting:

# On KeyShared subscriptions, with default AUTO_SPLIT mode, use splitting ranges or
# consistent hashing to reassign keys to new consumers
subscriptionKeySharedUseConsistentHashing=false

Change its default value to true.

The AUTO_SPLIT mode will not be removed nor deprecated. Users will still be
able to use the old implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants