Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][PIP-379] Hash ranges should not move from one consumer to another when a consumer joins #23439

Closed
lhotari opened this issue Oct 11, 2024 · 0 comments · Fixed by #23441
Closed

Comments

@lhotari
Copy link
Member

lhotari commented Oct 11, 2024

          > What happens if a hash is moved between existing consumers? Is it handled?

Yes. All removed ranges are processed in both when a consumer is added and when it's removed. In some experimental testing I noticed that it actually could happen also when a consumer is added, due to how hash range conflicts are resolved. There's a need to make an improvement that when there are conflicts that the first assigned consumer is preserved instead of replacing it. I'll make a PR for that since hash range conflicts are fairly likely to happen with the reduced hash range of 65535 and 100 hash points when there's a large amount of consumers. I'll address that.

Originally posted by @lhotari in #23352 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant