From 1c6d03704b391d9b5826381ce56ad0f56a092c14 Mon Sep 17 00:00:00 2001 From: maheshnikam <55378196+nikam14@users.noreply.github.com> Date: Thu, 14 Mar 2024 17:09:51 +0530 Subject: [PATCH 1/3] Update MetadataCache.java --- .../main/java/org/apache/pulsar/metadata/api/MetadataCache.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataCache.java b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataCache.java index 6d558e709716d..31f7e50e994c5 100644 --- a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataCache.java +++ b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataCache.java @@ -57,7 +57,7 @@ public interface MetadataCache { * * @param path * the path of the object in the metadata store - * @return the cached object or an empty {@link Optional} is the cache doesn't have the object + * @return the cached object or an empty {@link Optional} is the cache does not have the object */ Optional getIfCached(String path); From c697b7edb5baf94826638104b64277802e77dbbc Mon Sep 17 00:00:00 2001 From: maheshnikam <55378196+nikam14@users.noreply.github.com> Date: Fri, 15 Mar 2024 16:18:51 +0530 Subject: [PATCH 2/3] Update BaseMetadataStoreTest.java --- .../org/apache/pulsar/metadata/BaseMetadataStoreTest.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java b/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java index 491e3d0b9640c..c71c4b57fd429 100644 --- a/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java +++ b/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java @@ -145,10 +145,11 @@ public static void assertEqualsAndRetry(Supplier actual, int retryCount, long intSleepTimeInMillis) throws Exception { assertTrue(retryStrategically((__) -> { - if (actual.get().equals(expectedAndRetry)) { + Object Actual = actual.get(); + if (Actual.equals(expectedAndRetry)) { return false; } - assertEquals(actual.get(), expected); + assertEquals(Actual, expected); return true; }, retryCount, intSleepTimeInMillis)); } From d45a1bc4234b03e8d05c460ad9fbac07368d56ea Mon Sep 17 00:00:00 2001 From: maheshnikam <55378196+nikam14@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:50:36 +0530 Subject: [PATCH 3/3] changed local variable name --- .../org/apache/pulsar/metadata/BaseMetadataStoreTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java b/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java index c71c4b57fd429..d31835dae4b73 100644 --- a/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java +++ b/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/BaseMetadataStoreTest.java @@ -145,11 +145,11 @@ public static void assertEqualsAndRetry(Supplier actual, int retryCount, long intSleepTimeInMillis) throws Exception { assertTrue(retryStrategically((__) -> { - Object Actual = actual.get(); - if (Actual.equals(expectedAndRetry)) { + Object actualObject = actual.get(); + if (actualObject.equals(expectedAndRetry)) { return false; } - assertEquals(Actual, expected); + assertEquals(actualObject, expected); return true; }, retryCount, intSleepTimeInMillis)); }