Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric is wrongly written in BrokerRuntimeStats #111

Closed
MatrixHB opened this issue Sep 14, 2022 · 1 comment · Fixed by #113
Closed

Metric is wrongly written in BrokerRuntimeStats #111

MatrixHB opened this issue Sep 14, 2022 · 1 comment · Fixed by #113

Comments

@MatrixHB
Copy link
Contributor

loadTps(this.getTransferedTps, kvTable.getTable().get("getTransferedTps"));

The "getTransferedTps" is wrongly written, which should be "getTransferredTps" instead. This bug will cause NullPointerException when collecting metrics.

image
@MatrixHB MatrixHB mentioned this issue Sep 14, 2022
Merged
@0daypwn
Copy link

0daypwn commented Sep 20, 2022

目前使用的RocketMQ版本是 4.9.2，里面变量名是 getTransferedTps
这里是否应该对之前错误的 typo 进行兼容？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

solve problems of [ISSUE #111] and [ISSUE #112] MatrixHB/rocketmq-exporter
2 participants
@MatrixHB @0daypwn