Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][cdc sink clickhouse] Can timed writes be added to the cdc sink clickhouse #4953

Closed
2 of 3 tasks
zhaoyvli opened this issue Jun 20, 2023 · 6 comments · Fixed by #4999
Closed
2 of 3 tasks

Comments

@zhaoyvli
Copy link

Search before asking

  • I had searched in the feature and found no similar feature requirement.

Description

Can a timing configuration be added to write data to the clickhouse even if the number of data changes does not reach bulk_size within the specified time.

Usage Scenario

MySQL cdc write clickhouse. If the MySQL record update frequency is low and the number of records reaches bulk_size, data writing will be delayed. However, if bulk_size is reduced, frequent write operations will occur when the record update frequency is high. Therefore, even if the number of records in the specified time period does not reach the value of bulk_size, a timing configuration can be added to write clickhouse.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Carl-Zhou-CN
Copy link
Member

can assign it to me?

@zhaoyvli
Copy link
Author

sure, thanks.

@hailin0
Copy link
Member

hailin0 commented Jun 21, 2023

can assign it to me?

@Carl-Zhou-CN Assigned

@zhilinli123
Copy link
Contributor

zhilinli123 commented Jun 25, 2023

can assign it to me?

Do you have any good ideas or solutions for this timing writing? My previous implementation using a timed thread pool has completed a version but eventually the community did not choose to merge due to some resource issues!

CC: @Carl-Zhou-CN @Hisoka-X
close pr:#4328

@Carl-Zhou-CN
Copy link
Member

can assign it to me?

Do you have any good ideas or solutions for this timing writing? My previous implementation using a timed thread pool has completed a version but eventually the community did not choose to merge due to some resource issues!

CC: @Carl-Zhou-CN @Hisoka-X close pr:#4328

@zhilinli123 Thank you very much. My idea is to trigger a refresh based on the division of the checkpoints

@zhilinli123
Copy link
Contributor

can assign it to me?

Do you have any good ideas or solutions for this timing writing? My previous implementation using a timed thread pool has completed a version but eventually the community did not choose to merge due to some resource issues!
CC: @Carl-Zhou-CN @Hisoka-X close pr:#4328

@zhilinli123 Thank you very much. My idea is to trigger a refresh based on the division of the checkpoints

This is a nice idea to look forward to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants