Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WeOpen-Star] Support ShardingSphere parser of oracle sql. #17635

Closed
3 tasks done
tuichenchuxin opened this issue May 13, 2022 · 5 comments · Fixed by #20422 or #20463
Closed
3 tasks done

[WeOpen-Star] Support ShardingSphere parser of oracle sql. #17635

tuichenchuxin opened this issue May 13, 2022 · 5 comments · Fixed by #20422 or #20463
Assignees
Milestone

Comments

@tuichenchuxin
Copy link
Contributor

tuichenchuxin commented May 13, 2022

Hi community,

This issue is for WeOpen-Star
ref to #6480

Background

How is a SQL parsed?
SQL definition file
->(Parse to)
AST
->(Visit it)
SQLStatment

Process

  1. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc
  2. If there is any difference in ShardingSphere SQL Doc, please correct them referring to Official SQL Doc
  3. Run mvn install the current_file_module
  4. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class)
  5. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML
  6. Run SQLParserParameterizedTest to make sure no exceptions.

Notice

1.Left recursion can not work well in Antlr4,

a
  : b
  | a b
  ;
b
  : a c
  ;
c
  : ...
  ;

you can consider the following one,

a
  : b*
  ;
b
  : a c
  ;
c
  : ...
  ;
  1. Here is a Chinese version for reference.

subtask

  • ALTER PROCEDURE doc
  • CREATE PROCEDURE doc
  • DROP PROCEDURE doc
@kaori-seasons
Copy link
Contributor

I want to try this work

@terrymanu
Copy link
Member

Hi community, this issue still keep open to pick up.

@tianhao960
Copy link
Contributor

I would like to try

@strongduanmu
Copy link
Member

@tianhao960 Welcome, I will assign this issue to you.

@tianhao960
Copy link
Contributor

hi, @tuichenchuxin , I'm sorry that the pull request just fix the create procedure one; I'll post a new pr to fix the alter and drop statement. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment