Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for ShardingSphere Agent may can simplify things #20936

Closed
linghengqian opened this issue Sep 12, 2022 · 5 comments · Fixed by #21418
Closed

Documentation for ShardingSphere Agent may can simplify things #20936

linghengqian opened this issue Sep 12, 2022 · 5 comments · Fixed by #21418

Comments

@linghengqian
Copy link
Member

Question

For English only, other languages will not accept.

Before asking a question, make sure you have:

Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot reproduce it on current information, we will close it.

@linghengqian linghengqian changed the title Documentation for ShardingSphere Agent may simplify things Documentation for ShardingSphere Agent may can simplify things Sep 12, 2022
@RaigorJiang
Copy link
Contributor

Yes, modifying start.sh is a bit fiddly, especially in a container environment.
We should consider a way to quickly control whether to start the agent or not.

@github-actions
Copy link

github-actions bot commented Oct 8, 2022

Hello , this issue has not received a reply for several days.
This issue is supposed to be closed.

@github-actions github-actions bot closed this as completed Oct 8, 2022
@linghengqian
Copy link
Member Author

  • How should I reopen this issue? I'm just waiting for one of my PRs to be merged...

@RaigorJiang RaigorJiang reopened this Oct 9, 2022
@RaigorJiang
Copy link
Contributor

  • How should I reopen this issue? I'm just waiting for one of my PRs to be merged...

Hi @linghengqian , which PR is related to this issue?

@linghengqian
Copy link
Member Author

  • Actually I was talking about Fixes documentation for building GraalVM Native Image #21341 ,🤣 but due to recent changes in master branch, it had a merge conflict not long ago, which has now been resolved.
  • Since I don't really want to manage multiple PRs at the same time, I usually don't work on issues in parallel. For this current issue, I will submit a PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants