Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] <license and dependencies license check script> #3697

Closed
1 of 2 tasks
damonxue opened this issue Jul 12, 2022 · 5 comments
Closed
1 of 2 tasks

[Task] <license and dependencies license check script> #3697

damonxue opened this issue Jul 12, 2022 · 5 comments
Assignees
Labels
status: volunteer wanted Extra attention is needed

Comments

@damonxue
Copy link
Contributor

damonxue commented Jul 12, 2022

Description

task about : #3696

  1. Every file should check license-header.txt.
    refer to dubbo #6060
  2. dependencies license check script.
    refer to
    dubbo #3941
    history licenseCheck.sh

Task List

  • 1. codeStyle: file license header check.
  • 2. dependencies license check script.
@damonxue damonxue added the status: volunteer wanted Extra attention is needed label Jul 12, 2022
@damonxue
Copy link
Contributor Author

@yu199195 so, should i make a module with the name 'shenyu-build-tools' or some other name? and the licenseCheck use shell script or language script?

@yu199195
Copy link
Member

add license check plugin in root pom.xml

@damonxue
Copy link
Contributor Author

damonxue commented Jul 13, 2022

ok. License header is easy to use maven plugin to resolve. The third dependences's license chech must use script to do.

@yu199195
Copy link
Member

yu199195 commented Jul 14, 2022

@damonxue hi,can you add apache shenyu contributor wechat group? if not add my wechat:13786298670

@damonxue
Copy link
Contributor Author

damonxue commented Jul 16, 2022

chat with @yunlongn , i realize that apache-rat-plugin plugin has checked dependences license. and auto combine the license and notice is complex job when release. so the task 2 maybe unnecessary.

mvn Apache-rat:check
...
Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 7 licenses.
@yu199195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: volunteer wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants