-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed requests as required dependency #128
Conversation
So if you have nothing against it I will look into replacing requests with standard python lib urllib to do the connections? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need
FYI @potiuk This has been reverted and kept optional only. |
A different communication method? If requests is license problematic then why not change to standard python lib if possible, one less dependency too. |
Sorry, it was a copy/paste issue. There is no issue. This dependency issue should be resolved from the upstream repo already. |
Hey, I can see Sorry, you are right, mixup on my part. |
Correct. I mentioned that in my report. So this is right, it's not necesssary according to the ASF Policy (similarly in Airflow we have a lot of extras with |
Fix apache/skywalking#7282 due to #125