Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs from main README.md - Add website doc links. #164

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

Superskyyy
Copy link
Member

@Superskyyy Superskyyy commented Sep 13, 2021

  • Remove docs from main README.md

  • Add website doc links.

Waiting on apache/skywalking-website#330

Closes apache/skywalking#7687

Signed-off-by: Superskyyy Superskyyy@outlook.com

Signed-off-by: Superskyyy <Superskyyy@outlook.com>
@Superskyyy Superskyyy marked this pull request as ready for review September 13, 2021 03:54
@kezhenxu94 kezhenxu94 merged commit 73fdc7a into apache:master Sep 13, 2021
@kezhenxu94
Copy link
Member

FYI @Superskyyy python 3.5 is EOL and we failed to build the Docker images for it, maybe we can consider removing it from our Makefile

@Superskyyy
Copy link
Member Author

FYI @Superskyyy python 3.5 is EOL and we failed to build the Docker images for it, maybe we can consider removing it from our Makefile

I can see there are py3.5 kafka and grpc images in Docker Hub, the http one is missing, did it fail to build? I thought that just leads to a warning during the pull.

Python 3.10.0 final will come out on Monday, 2021-10-04, scheduled to release.

When that releases, I think probably remove it totally from the setup.py and move our support versions up to 3.10.

@kezhenxu94
Copy link
Member

@Superskyyy py3.5 failed to build b/c it failed to install requests==2.26, I think requests just dropped supporting py3.5 right before 2.26 😂

@Superskyyy
Copy link
Member Author

@Superskyyy py3.5 failed to build b/c it failed to install requests==2.26, I think requests just dropped supporting py3.5 right before 2.26 😂

o.O💧 Our requirements.txt shows requests == 2.24 though, my local build passed.

@wu-sheng
Copy link
Member

Another reminder, this docker hub repo is missing on the website, https://skywalking.apache.org/downloads/#docker-images-for-convenience. Please fix.

@kezhenxu94
Copy link
Member

when building the official docker images, it downloads the agent via pip and the requests version in setup.py takes effect, maybe you tested locally with requests==2.24 already installed, your tests passed indeed. Maybe installing requests==2.25 first and then install skywalking==0.7.0 in the Dockerfile do the trick 😉 but I'd rather drop support for py 3.5 directly as it's EOL

@Superskyyy
Copy link
Member Author

when building the official docker images, it downloads the agent via pip and the requests version in setup.py takes effect, maybe you tested locally with requests==2.24 already installed, your tests passed indeed. Maybe installing requests==2.25 first and then install skywalking==0.7.0 in the Dockerfile do the trick 😉 but I'd rather drop support for py 3.5 directly as it's EOL

Ah I see, that part I missed. Sure drop it.

@Superskyyy
Copy link
Member Author

Another reminder, this docker hub repo is missing on the website, https://skywalking.apache.org/downloads/#docker-images-for-convenience. Please fix.

Will add that in a minute.

@Superskyyy Superskyyy deleted the readme-refactor branch September 17, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Refactor current Python agent docs to serve on SkyWalking official website
3 participants