Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RabbitMQ BlockingChannel.basic_consume() to link with outgoing spans #224

Merged
merged 11 commits into from
Jul 18, 2022

Conversation

tom-pytel
Copy link
Contributor

Previously, incoming rabbitmq messages could not link to outgoing spans due to how the pika works internally. This is a workaround which fixes that at least for BlockingChannel.basic_consume(). Other types of channels will need their own workarounds (and can use this as a model).

@tom-pytel tom-pytel added the enhancement New feature or request label Jul 18, 2022
@tom-pytel tom-pytel added this to the 1.0.0 milestone Jul 18, 2022
@kezhenxu94
Copy link
Member

Can you check the failed unit tests?

@Superskyyy
Copy link
Member

LGTM

@tom-pytel tom-pytel merged commit 56f4efc into apache:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants