Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover grpcio tools codegen changes #253

Merged
merged 5 commits into from
Nov 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
- Pin CI SkyWalking Infra-E2E (#251)
- Sync OAP, SWCTL versions in E2E and fix test cases (#249)
- Overhaul development flow with Poetry (#249)
- Fix grpcio-tools generated message type (#253)

### 0.8.0
- Feature:
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ endif

.PHONY: gen
gen:
poetry run python3 -m grpc_tools.protoc --version || poetry run pip install grpcio-tools
poetry run pip install grpcio-tools packaging
poetry run python3 tools/grpc_code_gen.py

.PHONY: gen-basic
gen-basic:
python3 -m grpc_tools.protoc --version || python3 -m pip install grpcio-tools
python3 -m pip install grpcio-tools packaging
python3 tools/grpc_code_gen.py

.PHONY: install
Expand Down
Loading