Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance redis plugin to adapt Virtual Cache #263

Merged
merged 5 commits into from
Jan 2, 2023
Merged

Enhance redis plugin to adapt Virtual Cache #263

merged 5 commits into from
Jan 2, 2023

Conversation

Jedore
Copy link
Contributor

@Jedore Jedore commented Dec 29, 2022 •
edited
Loading

Resolves: #10212

@wu-sheng wu-sheng requested review from pg-yang, Superskyyy and kezhenxu94 and removed request for pg-yang December 29, 2022 06:44
@wu-sheng wu-sheng added this to the 1.0.0 milestone Dec 29, 2022
@wu-sheng wu-sheng added the enhancement New feature or request label Dec 29, 2022
@Jedore
Copy link
Contributor Author

Jedore commented Dec 30, 2022 •
edited
Loading

I'just a little confused. Do I have to make these checks all successful firstly?

@Superskyyy
Copy link
Member

Superskyyy commented Dec 30, 2022 •
edited
Loading

Hello @Jedore, yes you will have to make all checks pass to be eligible for a merge. The failed tests indicate problems in redis==3.5 plugin test (mismatch of expected data and reported), you can see the log in actions log.

Hint: please make modifications to the https://github.com/apache/skywalking-python/blob/master/tests/plugin/data/sw_redis/expected.data.yml file to make adjustments to expected data.

I'm recovering from Covid now so I don't check github very often, please ping me here when it passes, I will take a review then.

@Jedore
Copy link
Contributor Author

Jedore commented Dec 30, 2022

All checks have passed. @Superskyyy

Superskyyy
Superskyyy requested changes Dec 31, 2022
View reviewed changes
Copy link
Member

@Superskyyy Superskyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good, just some minor things. Thank you.

CHANGELOG.md Outdated Show resolved Hide resolved
skywalking/plugins/sw_redis.py Show resolved Hide resolved
Jedore and others added 2 commits January 1, 2023 21:40
@Jedore @Superskyyy
Update CHANGELOG.md
fd991ac 
Co-authored-by: Superskyyy (COVID) <Superskyyy@outlook.com>
@Jedore
Move the globals location
6504e26
@Jedore Jedore requested review from Superskyyy and removed request for kezhenxu94 January 1, 2023 13:53
@Superskyyy
Copy link
Member

LGTM thank you for the contribution!

@wu-sheng wu-sheng merged commit cf3a2ca into apache:master Jan 2, 2023
@Jedore Jedore deleted the redis branch February 3, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pg-yang pg-yang pg-yang left review comments

@Superskyyy Superskyyy Superskyyy approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

[Feature] [Python] Enhance redis plugin to adapt Virtual Cache UI
4 participants
@Jedore @Superskyyy @pg-yang @wu-sheng