Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slim in plugin tests #268

Merged
merged 13 commits into from
Jan 18, 2023
Merged

Use slim in plugin tests #268

merged 13 commits into from
Jan 18, 2023

Conversation

Superskyyy
Copy link
Member

@Superskyyy Superskyyy commented Jan 17, 2023 •
edited
Loading

Use slim to avoid long artifact build/download time in actions. (image size reduced by half)

If I understand correctly slim is only different in terms of minimal external-to-python libs and should in no way interfere with plugin tests. (build-essential is additionally installed in image)

Please indicate if there's potential risk in this one.

  • If this pull request closes/resolves/fixes an existing issue, replace the issue url. Closes:
  • Update the CHANGELOG.md.

@Superskyyy Superskyyy added the test test label Jan 17, 2023
@Superskyyy Superskyyy added this to the 1.0.0 milestone Jan 17, 2023
@Superskyyy Superskyyy self-assigned this Jan 17, 2023
Superskyyy
Superskyyy commented Jan 17, 2023
View reviewed changes
Copy link
Member Author

@Superskyyy Superskyyy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with the tests, investigating please don't merge
Done

@Superskyyy Superskyyy marked this pull request as draft January 17, 2023 23:17
kezhenxu94
kezhenxu94 previously approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when you mark it ready for review and CI passed 🧐

@Superskyyy
Copy link
Member Author

Superskyyy commented Jan 18, 2023 •
edited
Loading

LGTM when you mark it ready for review and CI passed 🧐

It will likely stuck forever 😂 Just found out there was a missed system-level dependency (for mysql-client) in the image. I'm fixing it right now.

@Superskyyy Superskyyy marked this pull request as ready for review January 18, 2023 02:34
@Superskyyy
Copy link
Member Author

Superskyyy commented Jan 18, 2023 •
edited
Loading

I also updated compose retries and ci output logic. It will never hang for 30minutes anymore.
(ready for review)

kezhenxu94
kezhenxu94 previously approved these changes Jan 18, 2023
View reviewed changes
@Superskyyy
Copy link
Member Author

zzZ my bad again.

wu-sheng
wu-sheng previously approved these changes Jan 18, 2023
View reviewed changes
@Superskyyy
Copy link
Member Author

Finially😔

@wu-sheng wu-sheng merged commit 748d451 into master Jan 18, 2023
@kezhenxu94 kezhenxu94 deleted the slim-ci-image branch January 18, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

Assignees

@Superskyyy Superskyyy

Labels
test test
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Superskyyy @wu-sheng @kezhenxu94