Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kafka prefix to kakfa topic names #277

Merged
merged 10 commits into from
Feb 6, 2023
Merged

Add kafka prefix to kakfa topic names #277

merged 10 commits into from
Feb 6, 2023

Conversation

SheltonZSL
Copy link
Contributor

Add new configuration kafka_namespace which will be used a prefix of the OAP-created Kafka topics.

@wu-sheng wu-sheng added the feature New feature label Feb 6, 2023
wu-sheng
wu-sheng previously approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng added this to the 1.0.0 milestone Feb 6, 2023
Superskyyy
Superskyyy reviewed Feb 6, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Superskyyy
Superskyyy requested changes Feb 6, 2023
View reviewed changes
Copy link
Member

@Superskyyy Superskyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, then it's good

@SheltonZSL
Copy link
Contributor Author

OK, I got it.

@Superskyyy Superskyyy self-requested a review February 6, 2023 01:51
kezhenxu94
kezhenxu94 approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 merged commit e0c97ba into apache:master Feb 6, 2023
@SheltonZSL SheltonZSL deleted the add-kafka-prefix branch February 12, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Superskyyy Superskyyy Superskyyy approved these changes

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@wu-sheng wu-sheng wu-sheng left review comments

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SheltonZSL @wu-sheng @kezhenxu94 @Superskyyy