-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] About log collecting and meter(Metrics) reports skywalking-rust. #9384
Comments
Is the log collecting means Span::add_log? If yes, it's already done. |
No, it isn't. Log collecting mean logs with trace context could be reported through grpc log API. It is less expensive than including in spans. Also, you would be able to search logs without trace ID. |
For logging, I want to implement it by integrate with the tokio log framework tracing, add the grpc subscriber and some filed in log, such as: // The GrpcSubscriber implement `tracing::Subscriber`.
let subscriber = skywalking::logging::GrpcSubscriber::new();
tracing::subscriber::set_global_default(subscriber);
let trace_context = create_the_trace_context();
info!("some log", skywalking.ctx = trace_context); Because tracing is not only a log framework, but also a trace framework, so in the future, I want to integrate skywalking Tracer with tracing, like tracing-opentelemetry. |
You could create APIs fot native logging/tracing integration, and provide a shell on the APIs for tokio tracing. This would be helpful to set up APIs boundaries. |
Add logging: |
I have some doubts about metric, where will the metric data be displayed on the UI? |
Nearly all data on the pages? You need to follow MAL to pre-process metrics |
You could take a look for k8s, virtual machine(linux), and MySQL server monitoring. |
👌 |
Log APIs - apache/skywalking-rust#41 |
Sorry to bother you but do we have any tokio tracing subscriber layer implemente by now? Is there any hint if I want to intergrate skywallking-rust with tokio tracing? |
What is that tracing doing? If it only does pure tracing such as Zipkin, I am afraid, that is not enough for SkyWalking's requirements. |
Tokio tracing is the most widely used trace framework in the Rust world. I'am not demanding that the crate skywalking-rust to support tokio tracing. I ask because the creator of this issue jmjoy mentioned that he was thinking about to integrate crate skywalking-rust with tokio tracing there like what tracing-opentelemetry do (maybe it's a new crate named |
That is a new thing. But at least, this is not a thing we discussed here. |
Search before asking
Description
Mentioned in #9297 (comment), the features of the next version of skywalking-rust.
Use case
No response
Related issues
No response
Are you willing to submit a PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: