Skip to content

Commit

Permalink
Apply review requests
Browse files Browse the repository at this point in the history
- Fix typo
- Cleanup TODOs
- Remove @SInCE reference
  • Loading branch information
malliaridis committed Nov 12, 2024
1 parent c3abf3a commit 4e8cc7f
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions solr/core/src/java/org/apache/solr/cli/CLIUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@

/**
* Utility class that holds various helper methods for the CLI.
*
* @since 10.0
*/
public final class CLIUtils {

Expand Down Expand Up @@ -134,14 +132,12 @@ public static SolrClient getSolrClient(String solrUrl, String credentials) {

public static SolrClient getSolrClient(CommandLine cli, boolean barePath) throws Exception {
String solrUrl = normalizeSolrUrl(cli);
// TODO Replace hard-coded string with Option object
String credentials = cli.getOptionValue(CommonCLIOptions.CREDENTIALS_OPTION);
return getSolrClient(solrUrl, credentials, barePath);
}

public static SolrClient getSolrClient(CommandLine cli) throws Exception {
String solrUrl = normalizeSolrUrl(cli);
// TODO Replace hard-coded string with Option object
String credentials = cli.getOptionValue(CommonCLIOptions.CREDENTIALS_OPTION);
return getSolrClient(solrUrl, credentials, false);
}
Expand Down Expand Up @@ -284,7 +280,7 @@ public static CloudHttp2SolrClient getCloudHttp2SolrClient(
* Extracts the port from the provided {@code solrUrl}. If a URL is provided with https scheme and
* not explicitly defines the port, the default port for HTTPS (443) is used.
*
* <p>If URL does not contain a port nor https as scheme, it fallsback to port 80.
* <p>If URL does not contain a port nor https as scheme, it falls back to port 80.
*
* @param solrUrl the URL to extract the port from
* @return The port that was found.
Expand Down

0 comments on commit 4e8cc7f

Please sign in to comment.