SOLR-17490: Check for existence of perl executable and skip if it doesnt exist #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patrbraun this one is for you! |
patrbraun
reviewed
Oct 11, 2024
|
I so want this; let's just require Java! |
janhoy
approved these changes
Oct 11, 2024
Co-authored-by: Jan Høydahl <jh@cominvent.com>
|
@patrbraun would you mind taking another stab with the latest change? |
|
It's working for me now. |
patrbraun
approved these changes
Nov 16, 2024
|
No Changes.txt needed, this is not user facing. |
epugh
added a commit
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17490
Description
Make the first time developer experience better with Solr. Today, everytime someone clones Solr for the first time, especially on Windows, they get bitten by the need to install perl.. just to product "Changes.html".
Solution
Add a check for the perl executable and log a warning if it isn't there, and continue on your Gradle process...
Tests
Manual